Uploaded image for project: 'LIMS'
  1. LIMS
  2. LIMS-1732

Calculated Uncertainty value as %, should have minimum value

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.1.7
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      For some low value results the calculated uncertainty gets a very low value which make no sense in some AS. For example:

      If an AS has a LD of 0.010 ug/L with an uncertainty factor of 2%, results close to LD looks like:

      Result: 0.012, calculated uncertainty: 0.0002, rounded result: 0.0120 +- 0.0002
      Result: 0.013, calculated uncertainty: 0.0003, rounded result: 0.0130 +- 0.0003

      Those calculated uncertainties make no sense. I suggest that there should be a field inside AS Uncertainty Tab to specified the lower uncertainty value for that given AS. If the calculate uncertainty is below the specified value it should display the limit value and round the results according to this number (if calculate precision from uncertainties is enable).

        Issue Links

          Activity

          Hide
          leonardorojass Leo added a comment -

          which are the changes you made?

          Show
          leonardorojass Leo added a comment - which are the changes you made?
          Hide
          krisalpha krishan chopra added a comment - - edited

          let my value be 0.001 with uncertainity 2 %, if i perform calculations on it it will be 0.001 +- 0.00002 . this is too small
          so for values which are lesser than 0.001, my change allows me to round off the uncertainty . if uncertainty < 5 % , it ignores it
          else it makes the uncertainty 10% , this saves an extra decimal place.

          Show
          krisalpha krishan chopra added a comment - - edited let my value be 0.001 with uncertainity 2 %, if i perform calculations on it it will be 0.001 +- 0.00002 . this is too small so for values which are lesser than 0.001, my change allows me to round off the uncertainty . if uncertainty < 5 % , it ignores it else it makes the uncertainty 10% , this saves an extra decimal place.
          Hide
          xispa Jordi (Inactive) added a comment -

          krishan chopra, thanks!, I've seen your modifications here:

          https://github.com/krisalpha/Bika-LIMS/commit/91339174422dbeeecacc3c88e04d6b7dad427ccd#diff-987b1ac1aff976a30a6d5424d16c5c44

          The idea suggested by Leo is to set this minimum allowed value in the Analysis Service View and use it later to prevent too lower uncertainties. You added the code inside a try-catch block, so not sure if your code will work, but in any case, is a good practice to not set values 'hardcoded' in the code.

          Show
          xispa Jordi (Inactive) added a comment - krishan chopra , thanks!, I've seen your modifications here: https://github.com/krisalpha/Bika-LIMS/commit/91339174422dbeeecacc3c88e04d6b7dad427ccd#diff-987b1ac1aff976a30a6d5424d16c5c44 The idea suggested by Leo is to set this minimum allowed value in the Analysis Service View and use it later to prevent too lower uncertainties. You added the code inside a try-catch block, so not sure if your code will work, but in any case, is a good practice to not set values 'hardcoded' in the code.
          Hide
          lemoene lemoene added a comment -

          Useful request. From Leo at Lab San Martin

          Show
          lemoene lemoene added a comment - Useful request. From Leo at Lab San Martin

            People

            • Assignee:
              Unassigned
              Reporter:
              leonardorojass Leo
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated: