Uploaded image for project: 'LIMS'
  1. LIMS
  2. LIMS-3114

Bulk Sample Import II. The Improvements

    Details

    • Type: New Feature
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      Overall

      1. Hidden rows

      I strongly propose we go with the hidden rows of the coded names indicating Field Values directly below them, as per annotated sheet 'Bika Dairy online at https://docs.google.com/spreadsheets/d/1AmDgYmMe5yoM3uOtvkpSzZu14pRYrXBmoTBkaPlTuUE, rows 1, 4 and 7. Soem code can be harvested from Bika Water and Cannabis' bulk imports that work like this

      Header

      1. I managed to successfully import the Vet Name and email address in the cc email fields, see Bulk 11.CSV.

      1.1 The Vet has to be a Verifier and not a Client contact, but he has to restricted to the Patients at his clients only, like a Client Contact. Leave as is for now, we could experiment with assigning Client Contact Verification authorisation

      1.2. We really only need the Vet name, the system could look the email address up. Not now, but user friendliness is key for the completing the spreadsheet

      2. New requirement.  Herd Read from the first Physical address line as per https://jira.bikalabs.com/browse/LIMS-3108

      Samples

      We can really only appropriate Sampling Date here from the old format...

      1. We need to use Samples' Client Reference field for the Patient ID 

      2. Until we do a 2 tier Sample structure, the value read in the *Sample Point *column, must be concatenated with the Patient ID, separated by full stop to make up the Sample Point on the DB. E.g  Cow 15006's sample points are on each quarter of its udder, thus becoming  15006.RB, 15006.RF, 15006.LB etc.

      3. Sample Time is required and since Spreadsheet date time pickers are clumsy, more so in the field, we used a separate column wit 10 minute interval look-up successfully before

      4. Sampler is required

      5. As is Container (NB - not Container Type as in older versions)

      6. and Preservation

        Activity

        Hide
        lemoene lemoene added a comment - - edited

        Reduced from Slack

        Mike Metcalfe:

        The SampleImporter code is complex because once a sample input file is loaded
        into a SamplerImport instance, we allow the instance of that class
        to be validated and edited. 
        
        Meaning that to to add a column to the input file
        one has to ensure that the Field can be edited, 
        and know its type (int, string, float), 
        maybe vocab the latter for validation purposes, etc. 
        
        To simplify the code to make it more flexible/extendable, 
        we could remove the editing feature. 
        
        This would allow us to add any new columns from addons.
        
        Am i correct in saying the only reason we need the extendable SampleImporter
        is because we need extra fields like Herd on the Sample?
        
        If this is the case then I will need to create that extender addon 
        so I can test any new SampleImporter.
        

        Good idea yes please, lose the editing feature and provide a user friendly error message for them to go edit the file and try importing again. That Error on Row x bit could be useful after all

        Show
        lemoene lemoene added a comment - - edited Reduced from Slack Mike Metcalfe : The SampleImporter code is complex because once a sample input file is loaded into a SamplerImport instance, we allow the instance of that class to be validated and edited.  Meaning that to to add a column to the input file one has to ensure that the Field can be edited, and know its type (int, string, float), maybe vocab the latter for validation purposes, etc. To simplify the code to make it more flexible/extendable, we could remove the editing feature. This would allow us to add any new columns from addons. Am i correct in saying the only reason we need the extendable SampleImporter is because we need extra fields like Herd on the Sample? If this is the case then I will need to create that extender addon so I can test any new SampleImporter. Good idea yes please, lose the editing feature and provide a user friendly error message for them to go edit the file and try importing again. That Error on Row x bit could be useful after all
        Hide
        lemoene lemoene added a comment -

        Note Mike Metcalfe, we won't get away with just 5 Sample points (RB, RF, LB, LR and Composite) as won't be able to look individual cows' results up I realised.

        All suggestions welcome - we have more labs interested in 2 tier sample points, whether they'll pau is another question. MAybe we should quote and put it out there

        Show
        lemoene lemoene added a comment - Note Mike Metcalfe , we won't get away with just 5 Sample points (RB, RF, LB, LR and Composite) as won't be able to look individual cows' results up I realised. All suggestions welcome - we have more labs interested in 2 tier sample points, whether they'll pau is another question. MAybe we should quote and put it out there

          People

          • Assignee:
            lemoene lemoene
            Reporter:
            lemoene lemoene
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated: