Uploaded image for project: 'LIMS'
  1. LIMS
  2. LIMS-3195

Reconfigure Sample Types, Points

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      From email

      There is no physical difference between all the Raw milk samples, are there? Raw milk (bulk tank), Raw milk (composite sample) and Raw milk (quarter sample)

      It caught my eye earlier, as from a DB analysis perspective it did not look right, and secondly because they are quite long and could start messing with table lay-outs, which it now does on the COA, where we cannot fit iv more than say 5 Samples per page before the cells in the result table starts misbehaving and the COA paging collapses completely. It is a bug, but only came to the surface now that we have to facilitate these long texts

      A more correct config would be to just have one Sample Type, Raw Milk, and do the differentiation in the Sample point, the Tank no, RB, RL, LB, LF or say Udder all for the composite udder samples. The system has a Composite Y/N flag that can be applied to any composite sample. It is normally used for mixing borehole samples at different depths or surface water samples for a dam. Calling a variable the same is not good practice.

      Is not a big modification and can be fixed up in minutes. Shall I go ahead? What should the composite Udder Sample Point be called?

        Activity

        Hide
        lemoene lemoene added a comment -

        Deactivated the fifferentiated Raw milk types, they are stillthere, and added Raw Milk for next round of testing

        Show
        lemoene lemoene added a comment - Deactivated the fifferentiated Raw milk types, they are stillthere, and added Raw Milk for next round of testing
        Hide
        lemoene lemoene added a comment -

        Composite Y/N is built into the system and not needed in Sample Point title. I modified the Udder sample Points to be called

        Udder Full
        Udder LB
        Udder LF
        Udder RB
        Udder RF

        Show
        lemoene lemoene added a comment - Composite Y/N is built into the system and not needed in Sample Point title. I modified the Udder sample Points to be called Udder Full Udder LB Udder LF Udder RB Udder RF
        Hide
        shaun Shaun Groenink added a comment -

        Yes, all good. essentially the same thing.

        Show
        shaun Shaun Groenink added a comment - Yes, all good. essentially the same thing.

          People

          • Assignee:
            lemoene lemoene
            Reporter:
            lemoene lemoene
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: