Uploaded image for project: 'Wine'
  1. Wine
  2. WINE-44

Partitions showing where they should not. Sample sticker

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Elsewhere i saw it on the AR Template still. Partitions are disabled on the set-up

      Will load a sticker shot next

        Issue Links

          Activity

          Hide
          lemoene lemoene added a comment -

          This Sample then has no mention of partitions

          Show
          lemoene lemoene added a comment - This Sample then has no mention of partitions
          Hide
          lemoene lemoene added a comment -

          But the sticker still includes P1

          And the barcode likely too?

          Show
          lemoene lemoene added a comment - But the sticker still includes P1 And the barcode likely too?
          Hide
          lemoene lemoene added a comment -

          This has become a blocker preventing (i think) the correct importation of instrument results files where the Sample IDs were scanned from their labels...

          Actually belongs in LIMS

          Show
          lemoene lemoene added a comment - This has become a blocker preventing (i think) the correct importation of instrument results files where the Sample IDs were scanned from their labels... Actually belongs in LIMS
          Hide
          lemoene lemoene added a comment -

          the P1 must be dropped from both the bar-code and human readible ID

          Show
          lemoene lemoene added a comment - the P1 must be dropped from both the bar-code and human readible ID
          Hide
          rockfruit Campbell added a comment -

          Removing from label is one part of it, I think the instrument result import part needs to get fixed in the importer for that instrument, where it must assume that the id SAMPLE-001 should refer to SAMPLE-001-P1 behind the scenes.

          Show
          rockfruit Campbell added a comment - Removing from label is one part of it, I think the instrument result import part needs to get fixed in the importer for that instrument, where it must assume that the id SAMPLE-001 should refer to SAMPLE-001-P1 behind the scenes.
          Hide
          lemoene lemoene added a comment -

          mmm all the instruments will have to be done, but I don't think it is necessary: If both the import file and the sample is labelled W15-0007 there is no problem. The import failure in https://jira.bikalabs.com/browse/WINE-41 happened because the sample label was scanned into the instrument, and it picked up W15-0007-P1 off the barcode in stead of W15-0007.

          Just fixing the label should be enough IMO. Please do that and we see how it goes. However, and NB Jordi, Pau Soliva: What happened to using AR IDs for matching imported results to their analyses? In the case of secondary ARs on the same Sample with results due on both ARs, W15-0007 or W15-0007-P1 is not going to be enough to identify the the correct Analysis for the results. I think this was discussed and it is sorted, but please re-assure me

          Show
          lemoene lemoene added a comment - mmm all the instruments will have to be done, but I don't think it is necessary: If both the import file and the sample is labelled W15-0007 there is no problem. The import failure in https://jira.bikalabs.com/browse/WINE-41 happened because the sample label was scanned into the instrument, and it picked up W15-0007- P1 off the barcode in stead of W15-0007. Just fixing the label should be enough IMO. Please do that and we see how it goes. However, and NB Jordi , Pau Soliva : What happened to using AR IDs for matching imported results to their analyses? In the case of secondary ARs on the same Sample with results due on both ARs, W15-0007 or W15-0007-P1 is not going to be enough to identify the the correct Analysis for the results. I think this was discussed and it is sorted, but please re-assure me
          Hide
          lemoene lemoene added a comment -

          Jip Campbell, i hacked the P1 out of the results file and it worked

          Show
          lemoene lemoene added a comment - Jip Campbell , i hacked the P1 out of the results file and it worked
          Hide
          rockfruit Campbell added a comment -

          PR pending

          Show
          rockfruit Campbell added a comment - PR pending

            People

            • Assignee:
              rockfruit Campbell
              Reporter:
              lemoene lemoene
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: